[PATCH] D69590: [RISCV] Fix ILP32D lowering for double+double/double+int return types

Sam Elliott via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 7 09:23:11 PST 2019


lenary added a comment.

In D69590#1728628 <https://reviews.llvm.org/D69590#1728628>, @asb wrote:

> Thanks James - won't this still leave problems for structs that need flattening?


The tests in clang/test/CodeGen/riscv32-ilp32d-abi.c already include lots of cases that include flattening.

I suppose the one place they lack tests is probably a complex type passed within a struct, which would be good to add @jrtc27. Though, we should probably greatly expand the testing of `_Complex` within ABIs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69590/new/

https://reviews.llvm.org/D69590





More information about the cfe-commits mailing list