[PATCH] D53482: Add clang-format stability check with FormatTests

Wouter van Oortmerssen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 7 09:23:09 PST 2019


aardappel added a comment.

@MyDeveloperDay thanks for your thoughts.. while `-stable` would be helpful once you know you have the issue (or to permanently turn on in a git pre-submit), it does not help developers that don't even know this is a thing, and waste a bunch of time figuring out what is going on. In fact, it took me longer to figure out simply because I assumed it is unlikely that `clang-format` has such a bug :)

It might almost make sense in reverse: `-stable` by default, and have a `-un-stable` for those users where `clang-format` becomes a performance bottleneck :) But once you admit that, might as well fix the core problem instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53482/new/

https://reviews.llvm.org/D53482





More information about the cfe-commits mailing list