[PATCH] D69937: [clangd] Use name of Macro to compute its SymbolID.
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 7 06:46:02 PST 2019
hokein added a comment.
In D69937#1736980 <https://reviews.llvm.org/D69937#1736980>, @ilya-biryukov wrote:
> Does that mean we identify each macro merely by its name?
> It's not uncommon to have multiple `#define` for the same name, meaning completely different things.
>
> If find references shows all of those, it's not very useful...
no, I would say this patch is NFC, we still construct macro symbol id with macro name and definition location.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69937/new/
https://reviews.llvm.org/D69937
More information about the cfe-commits
mailing list