[PATCH] D69937: [clangd] Use name of Macro to compute its SymbolID.

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

there are some unrelated changes in this patch (probably trigger by your editor setting?), though they are trivial, I would avoid these changes in a same patch.



================
Comment at: clang-tools-extra/clangd/AST.cpp:238
 
-std::string printType(const QualType QT, const DeclContext & Context){
+std::string printType(const QualType QT, const DeclContext &Context) {
   PrintingPolicy PP(Context.getParentASTContext().getPrintingPolicy());
----------------
hmm, this is a unrelated change.


================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1768
   semaCodeComplete(
-      std::make_unique<SignatureHelpCollector>(Options, Index, Result),
-      Options,
+      std::make_unique<SignatureHelpCollector>(Options, Index, Result), Options,
       {FileName, Command, Preamble, Contents, *Offset, std::move(VFS)});
----------------
same here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69937/new/

https://reviews.llvm.org/D69937