[PATCH] D69869: [clang-tools-extra] fix the check for if '-latomic' is necessary
Saleem Abdulrasool via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 6 19:01:47 PST 2019
compnerd added a comment.
I agree with @efriedma that it sounds odd, could you explain that please?
It took about 3 reads before I saw the OUT in the WITHOUT, and then realized that this was just: `NOT (HAVE_CXX_ATOMICS_WITHOUT_LIB AND HAVE_CXX_ATOMICS64_WITHOUT_LIB)`. I don't know if there is a better way to write this though. Given the similar change that was made elsewhere in the build, I think that the change from the build perspective makes sense and is correct. Perhaps a little note for readers would be helpful to indicate that this is the negation of the pair so that its easier to spot the fact that the variable themselves are negated.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69869/new/
https://reviews.llvm.org/D69869
More information about the cfe-commits
mailing list