[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

Paul Robinson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 6 09:22:32 PST 2019


probinson added a comment.

Just a couple of typos, and I'm happy.  I agree with the other reviewers on the last needed test tweaks.



================
Comment at: clang/include/clang/Driver/Options.td:1955
   Flags<[CC1Option]>;
+def fdebug_default_version: Joined<["-"], "fdebug-default-version=">, Group<f_Group>, HelpText<"Default DWARF version to use, if a -g option caused DWARF debug info to be produced.">;
 def fdebug_prefix_map_EQ
----------------
HelpText does not want a final period.


================
Comment at: clang/test/Driver/debug-default-version.c:10
+// The -isysroot is used as a hack to avoid LIT messing with the SDKROOT
+// environment variable which indirecty overrides the version in the target
+// triple used here.
----------------
indirectly


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69822/new/

https://reviews.llvm.org/D69822





More information about the cfe-commits mailing list