[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

[Paul Robinson via Phabricator via cfe-commits]

probinson added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:1955
   Flags<[CC1Option]>;
+def fdebug_default_version: Joined<["-"], "fdebug-default-version=">, Group<f_Group>;
 def fdebug_prefix_map_EQ
----------------
dblaikie wrote:
> probinson wrote:
> > If this is specifically the default DWARF version, I think the word "dwarf" ought to be in the option name.
> Can we haggle over this a bit?
> 
> My thinking behind -fdebug-default-version was consistency with other DWARF related flags:
> -fdebug-compilation-dir
> -fdebug-info-for-profiling
> -fdebug-macro
> -fdebug-types-section
> -fdebug-ranges-base-address
> -fdebug-prefix-map
> 
> 
> We do have some -fdwarf:
> -fdwarf2-cfi-asm
> -fdwarf-directory-asm
> -fdwarf-exceptions
> 
> So I'm personally inclined to sticking with -fdebug* as being all DWARF related/consistent there.
> 
> Thoughts?
> 
If the HelpText mentions DWARF, I'm okay with an `-fdebug` prefix.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69822/new/

https://reviews.llvm.org/D69822