[PATCH] D59425: Explicitly Craft a Path to Compiler-RT Builtins on Bare Metal Targets

[Petr Hosek via Phabricator via cfe-commits]

phosek added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:173
+  }
+
+  // Builds of compiler-rt on bare-metal targets are specialized by specific
----------------
CodaFi wrote:
> phosek wrote:
> > Would it be possible to support the [per-target runtimes directory layout](https://github.com/llvm/llvm-project/blob/master/clang/lib/Driver/ToolChain.cpp#L391) as well?
> Does that make sense in the context of bare metal triples?  My understanding of the layout of the resource directory for these targets is hazy, but I was under the impression that each target architecture having its own namespaced copy of compiler-rt in `<RESOURCE_DIR>/lib` *is* how we do per-target runtimes.
The per-target runtimes directory layout always expects a triple, i.e. `<RESOURCE_DIR>/lib/<triple>`. In case of bare metal, the triple would be e.g. `armv6m-none-eabi`.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59425/new/

https://reviews.llvm.org/D59425