[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 5 10:29:13 PST 2019


ABataev added a comment.

In D69785#1734292 <https://reviews.llvm.org/D69785#1734292>, @jdoerfert wrote:

> In D69785#1734205 <https://reviews.llvm.org/D69785#1734205>, @ABataev wrote:
>
> > Also, I think it would better to split LLVM part and clang part into separate patches.
>
>
> What do you mean exactly and why?


I just think it would be better to split this patch into 2 parts, one for LLVM builder (without tests, probably, or just with some kind of unittests) + another one for clang-related changes. It will reduce the size of the patches and all that stuff related to `keep patches smaller`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69785/new/

https://reviews.llvm.org/D69785





More information about the cfe-commits mailing list