[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

[Paul Robinson via Phabricator via cfe-commits]

probinson added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1151
+      || Value > 5
+      || Value < 1)
+    TC.getDriver().Diag(diag::err_drv_invalid_int_value)
----------------
dblaikie wrote:
> probinson wrote:
> > Clang doesn't support DWARF v1.  I expect nobody does at this point (DWARF 2 came out in 1993).
> You'd recommend/request moving this bound up to 2 (to be consistent with the fact that clang supports -gdwarf-2 technically (even though we probably don't produce fully conformant DWARFv2 these days, I would guess))?
It wants to permit the exact same range as the -gdwarf-N options.


================
Comment at: clang/test/CodeGen/debug-default-version.c:24
+// disables codeview, of you can explicitly ask for both if you don't know how
+// the app will be debugged.
+// RUN: %clang -target i686-pc-windows-msvc -fdebug-default-version=2 -gdwarf -S -emit-llvm -o - %s \
----------------
dblaikie wrote:
> probinson wrote:
> > Does that actually work?  Last I checked, DWARF and COFF didn't play nicely, but I admit that was quite a while ago.
> Existing test cases cover scenarios like this (see clang/test/CodeGen/dwarf-version.c), so this seems consistent to preserve that sort of functionality, however well it currently works.
Ok.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69822/new/

https://reviews.llvm.org/D69822