[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

Mon Nov 4 14:53:44 PST 2019

dblaikie added a comment.

In D69822#1733258 <https://reviews.llvm.org/D69822#1733258>, @aprantl wrote:

> Since this sounds like it is hidden inside of some other tooling — is passing the frontend option `-dwarf-version=5` not an option?

"hidden inside of some other tooling" - in the same sense as most build flags are passed by a build system, yes. But generally we (Google specifically, all of us LLVM/Clang users in general) try not to use implementation details like that.

================
Comment at: clang/test/CodeGen/debug-default-version.c:24
+// disables codeview, of you can explicitly ask for both if you don't know how
+// the app will be debugged.
+// RUN: %clang -target i686-pc-windows-msvc -fdebug-default-version=2 -gdwarf -S -emit-llvm -o - %s \
----------------
probinson wrote:
> Does that actually work?  Last I checked, DWARF and COFF didn't play nicely, but I admit that was quite a while ago.
Existing test cases cover scenarios like this (see clang/test/CodeGen/dwarf-version.c), so this seems consistent to preserve that sort of functionality, however well it currently works.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69822/new/

https://reviews.llvm.org/D69822