[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

[Roger Ferrer Ibanez via Phabricator via cfe-commits]

rogfer01 added a comment.

Hi @jdoerfert, thanks a lot for putting this up this initial skeleton and providing an example with `barrier`.

I made a small experiment lowering a `taskwait` (which is even simpler than `barrier` in "lowering" complexity). It was pretty straightforward after all.

I have a few questions just to reassure I fully understand your vision here:

- the parameter `Loc` is currently unused but my understanding from the comment in `OpenMPIRBuilder::getSrcLocStr` eventually we will convert a `clang::SourceLocation` to a `llvm::Constant*` that represents the location as used by KMP, right?
- emitting a `taskwait` however has this

  if (auto *Region = dyn_cast_or_null<CGOpenMPRegionInfo>(CGF.CapturedStmtInfo))
    Region->emitUntiedSwitch(CGF);

but my understanding is that we can apply the same scheme to these hooks as well, recursively, i.e.: progressively convert them to calls to `OpenMPIRBuilder` (if needed under the flag suggested above by Alexey). Does this make sense?

Kind regards,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69785/new/

https://reviews.llvm.org/D69785