[PATCH] D69745: [analyzer] Checker: check::BeginAnalysis

[Csaba Dabis via Phabricator via cfe-commits]

Charusso abandoned this revision.
Charusso marked an inline comment as done.
Charusso added a comment.

In D69745#1732739 <https://reviews.llvm.org/D69745#1732739>, @NoQ wrote:

> Basically this, but the other way round: your `BeginAnalysis` is `BeginFunction` with extra steps (namely, checking `C.inTopFrame()`).
>
> Backstory: I wanted to add `BeginAnalysis` a few years ago because i wanted to mark `argc` and `argv` as tainted when analyzing `main()`. But then i noticed that we already have `BeginFunction` so i decided not to add it. No, i didn't mark them as tainted yet :/


Hm, that is a cool workaround. I think every `UnknownSpaceRegion` stuff is tainted, and that is a strong mark here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69745/new/

https://reviews.llvm.org/D69745