[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert marked 7 inline comments as done.
jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/IR/OpenMPIRBuilder.h:33
+  /// IDs for all OpenMP directives.
+  enum DirektiveKind {
+#define OMP_DIRECTIVE(Enum, ...) Enum,
----------------
ABataev wrote:
> jdoerfert wrote:
> > ABataev wrote:
> > > 1. `DirectiveKind`
> > > 2. Is it possible to merge these 2 types in LLVM and in clang into 1?
> > 1. Agreed.
> > 2. Yes! Clang needs to eventually use the one here. I can already make that change now or we wait a bit longer and have both coexist. The change would probably be something along the lines of: `using OpenMPDirectiveKind = llvm::OpenMPIRBuilder::DirectiveKind` in clang instead of the enum definition. We probably also want to include `llvm/IR/OpenMPKinds.def` where `OPENMP_DIRECTIVE_EXT` is now used. 
> Maybe introduce `llvm/IR/OpenMPKinds.def` and make clang use it in a separate NFC patch?
Working on it already :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69785/new/

https://reviews.llvm.org/D69785