[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

[Marek Kurdej via Phabricator via cfe-commits]

curdeius added a comment.

Minor comments.



================
Comment at: clang/lib/Format/TokenAnnotator.cpp:1354
+  static FormatToken *untilMatchingParen(FormatToken *Current) {
+    // for when MatchingParen is not yet established
+    int ParenLevel = 0;
----------------
Please write full-phrase comments.


================
Comment at: clang/unittests/Format/FormatTest.cpp:4995
+  verifyFormat("c()->f<int>();");
+  verifyFormat("x()->foo<1>;");
+  verifyFormat("x = p->foo<3>();");
----------------
What about:

```
verifyFormat("x()->x<1>;");
```
i.e. a function `x` returning a pointer to a class having a template member `x` (for instance a template variable).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69577/new/

https://reviews.llvm.org/D69577