[PATCH] D69760: [LLD][MinGW] Support --allow-multiple-definition

John Ericson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 3 01:07:57 PST 2019


Ericson2314 created this revision.
Herald added subscribers: llvm-commits, cfe-commits, mstorsjo.
Herald added projects: clang, LLVM.

We want the Clang CrossWindows toolchain to work with ld.lld and ld.bfd
alike, and it uses this, so we need to support this.

[Clang][Test]: Remaining "lld-link2" -> "lld-link"

No idea why these are still here.

[Clang][MSVC] Use GetLinkerPath like the other toolchains for consistency

[Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

Besides the Mingw toolchain, there is also the CrossWindows toolchain,
which means GNU-style cli but genuine windows headers + libraries. LLD's
MinGW driver is as good a fit as binutil's ld, but there is no easy way
to select it when lld was being rewritten to lld-link.

This makes lld always be the GNU-style one, consistent with the non-msvc
case. It's a small breaking change for Windows, but the only
straightforward way.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D69760

Files:
  clang/lib/Driver/Driver.cpp
  clang/lib/Driver/ToolChains/MSVC.cpp
  clang/test/Driver/fuse-ld.c
  clang/test/Driver/windows-cross.c
  lld/MinGW/Driver.cpp
  lld/MinGW/Options.td
  lld/test/MinGW/driver.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69760.227602.patch
Type: text/x-patch
Size: 8362 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191103/d2713a32/attachment.bin>


More information about the cfe-commits mailing list