[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

Sat Nov 2 16:07:57 PDT 2019

krytarowski marked an inline comment as done.
krytarowski added inline comments.

================
Comment at: lld/tools/nb.lld/nb.lld.cpp:94
+
+  // disable superfluous RUNPATH on NetBSD
+  args.push_back("--disable-new-dtags");
----------------
MaskRay wrote:
> You can't use DT_RUNPATH probably because the change `Add support for DT_RUNPATH - it is just the same as we always have treated DT_RPATH.  Approved by core.` (2018-12-30) is still considered new. If you do this in clangDriver, you need a comment with a TODO about the migration process.
I am pretty sure that the only reason to pick it was rust (prebuilt snapshot) and its hard-coding of RUNPATH. We still want to disable it everywhere always.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69755/new/

https://reviews.llvm.org/D69755