[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

[Chi Chun Chen via Phabricator via cfe-commits]

cchen marked an inline comment as done.
cchen added inline comments.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7368-7370
+      bool IsImplicit, OpenMPDefaultmapClauseModifier ImplicitBehavior =
+          OMPC_DEFAULTMAP_MODIFIER_default,
+      OpenMPDefaultmapClauseKind VariableCategory = OMPC_DEFAULTMAP_unknown,
----------------
ABataev wrote:
> Do you really need the default params values here?
I'm doing so since ImplicitBehavior and VariableCategory is only used when the  `generateInfoForComponentList` is called inside `generateInfoForCapture`, and for other control flow, such as `generateInfoForComponentList` called inside `generateInfoForDeclareTargetLink`, we don't need to set this two argument .


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69204/new/

https://reviews.llvm.org/D69204