[PATCH] D69184: [libTooling] Introduce general combinator for fixed-value `MatchConsumer`s.

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 1 11:27:29 PDT 2019


gribozavr2 added a comment.

> In fact, it might be a good idea to rename `change` to `changeTo` (WDYT?).

I like it. It should combine well with all stencils, not just `text`.

> An alternative, is not to introduce a new combinator at all, and just use Stencils:

I think we are converging on that in another review. Do you plan to pursue this patch still?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69184/new/

https://reviews.llvm.org/D69184





More information about the cfe-commits mailing list