[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 1 01:15:42 PDT 2019


MyDeveloperDay marked 5 inline comments as done.
MyDeveloperDay added inline comments.


================
Comment at: clang/lib/Format/TokenAnnotator.cpp:2105
+      if ((Next->isSimpleTypeSpecifier() || Next->is(tok::identifier)) &&
+          Next->Next && Next->Next->is(tok::star)) {
+        // For operator void*(), operator char*(), operator Foo*().
----------------
sammccall wrote:
> I'm suspicious of code that handles star but not amp, though maybe I shouldn't be.
added those and mutated your test cases to cover that


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69573/new/

https://reviews.llvm.org/D69573





More information about the cfe-commits mailing list