[PATCH] D69625: [libTooling] Support implicit coercions in Stencil's `access` combinator.

[Dmitri Gribenko via Phabricator via cfe-commits]

gribozavr2 added a comment.

I fully agree about passing a Stencil to `access`. However whether to call `makeStencil` inside is an interesting question. On one hand, such implicit conversions increase the convenience. On the other, they increase the API surface (more possible argument types), and makes the API harder to read. What does `access` take? "I don't know, some T" vs. "A Stencil".

I think that implicit conversions for `cat` arguments can be justified because it seems like `cat` will be used frequently; however, `access` won't be as frequently called.

What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69625/new/

https://reviews.llvm.org/D69625