[PATCH] D69626: Fix Microsoft compatibility handling of commas in nested macro expansions.

[Reid Kleckner via Phabricator via cfe-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

Based on the comments it looks like you confirmed this matches MSVC's behavior, at least in this regard. I haven't stared at this deeply to think of all the corner cases, though.

To Nico's point, I think this change doesn't move us away from conformance, it's a bug in our compatibility. We've created a bad situation here were we are buggily implementing MSVC pre-processor rules, and nobody should have to add a third set of ifdefs to deal with that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69626/new/

https://reviews.llvm.org/D69626