[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 31 11:38:21 PDT 2019


tra added a comment.

Could you, please, give us a bit more context and provide more info for the questions @rjmccall and I asked before?

Is the problem specifically because autolink is not supported on device side? Or is disabling autolink just a convoluted way to avoid calling EmitModuleLinkOptions()?
If it's the former, then we should just disable it unconditionally -- we already filter out some other flags  (e.g. asan).
If it's the latter, then tweaking autolink option behavior is just covering the problem. Sooner or later EmitModuleLinkOptions() will be called by something else and we'll be back to where we are now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57829/new/

https://reviews.llvm.org/D57829





More information about the cfe-commits mailing list