[PATCH] D14927: clang-format: Add SpaceBeforeTemplateParameterList option

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 31 03:26:23 PDT 2019


MyDeveloperDay added inline comments.


================
Comment at: include/clang/Format/Format.h:500
+  /// bracket of a template parameter list.
+  bool SpaceBeforeTemplateParameterList;
+
----------------
I suggest we make this an enumeration

```
enum {
Unaltered,
Never,
Always,
}
```

Introducing this into a codebase means we need to select a suitable default, doing nothing would in my view be the best default and introducing anything new now will cause a tidal wave of changes on any existing formatted code base

LLVM alone it pretty much 50/50 on if they use a space or not


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D14927/new/

https://reviews.llvm.org/D14927





More information about the cfe-commits mailing list