[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

Thu Oct 31 01:07:31 PDT 2019

xbolva00 marked an inline comment as done.
xbolva00 added inline comments.

================
Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:334
+  "'%0' will always evaluate to 'true' in constexpr context">,
+  InGroup<DiagGroup<"constant-evaluated">>;
+
----------------
rsmith wrote:
> Looks like you decided not to make this a subgroup of tautological-compare? (I'm OK with that, I just wanted to make sure this was intentional given the prior discussion.)
Yes, I decided to go with a new group since the warning is more powerful than gcc's version of this warning.

>> The technically-correct thing would be "in a manifestly constant-evaluated expression".

I will use this message - Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69518/new/

https://reviews.llvm.org/D69518