[PATCH] D69626: Fix Microsoft compatibility handling of commas in nested macro expansions.

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 30 18:49:05 PDT 2019


thakis added a comment.

Is this needed to parse system headers?

In general, we try to emulate only warts we must emulate, and if feasible we try to emit some -Wmicrosoft warning when the compat path is taken.

(MSVC added /experimental:preprocessor like 2 years ago, but it hasn't made it to a /Zc: flag yet so I suppose standard headers might keep needing these tweaks.)

(See https://docs.google.com/presentation/d/1oxNHaVjA9Gn_rTzX6HIpJHP7nXRua_0URXxxJ3oYRq0/edit#slide=id.g71ecd450e_2_843 slide 23-27)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69626/new/

https://reviews.llvm.org/D69626





More information about the cfe-commits mailing list