[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Wed Oct 30 13:53:26 PDT 2019

aaron.ballman added a comment.

In D68539#1727759 <https://reviews.llvm.org/D68539#1727759>, @Daniel599 wrote:

> In D68539#1727503 <https://reviews.llvm.org/D68539#1727503>, @aaron.ballman wrote:
>
> > Thank you for the patch! I've commit on your behalf in e477988309dbde214a6d16ec690a416882714aac <https://reviews.llvm.org/rGe477988309dbde214a6d16ec690a416882714aac>
>
>
> Thank you for the commit,
>  just a little question. shouldn't the test file `clang-tools-extra/test/clang-tidy/readability-identifier-naming-bugfix-name-conflicts.cpp` be added?

It absolutely should have been, but I don't see why it didn't get added. I've fixed it in 7b6174bb147957b4695023ae57c95ca07af7b917 <https://reviews.llvm.org/rG7b6174bb147957b4695023ae57c95ca07af7b917>, thank you for bringing it to my attention!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68539/new/

https://reviews.llvm.org/D68539