[PATCH] D69498: IR: Invert convergent attribute handling

[Mehdi AMINI via Phabricator via cfe-commits]

mehdi_amini added a comment.

In D69498#1727546 <https://reviews.llvm.org/D69498#1727546>, @jdoerfert wrote:

> In D69498#1727419 <https://reviews.llvm.org/D69498#1727419>, @mehdi_amini wrote:
>
> > In D69498#1727080 <https://reviews.llvm.org/D69498#1727080>, @jdoerfert wrote:
> >
> > > Let me quote @arsenm here because this is so important: "Basically no frontend has gotten this right, including clang and non-clang frontends." For me, that statement alone is reason to change the status quo.
> >
> >
> > I am not convinced by this: this seems overly simplistic. The fact that convergent wasn't rolled out properly in frontend can also been as an artifact of the past.
>
>
> Evidence suggest this problem will resurface over and over again, calling it an artifact of the past is dangerous and not helpful.


Can you provide the "evidence"? So far the only thing I have seen is historical and closely tied to how convergence was rolled out AFAICT.

>> There is a logical gap between this and concluding that the only solution is to change the default.
> 
> There is no gap.

Bluntly contradicting what I wrote without apparently trying to understand my point or trying to explain your point with respect to what I'm trying to explain is not gonna get me to agree with you magically, I'm not sure what you expect here other than shutting down the discussion and leaving us in a frustrating disagreement and lack of understanding with this?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69498/new/

https://reviews.llvm.org/D69498