[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

Wed Oct 30 12:00:28 PDT 2019

daltenty added a comment.

In D69356#1727581 <https://reviews.llvm.org/D69356#1727581>, @hubert.reinterpretcast wrote:

> In D69356#1727484 <https://reviews.llvm.org/D69356#1727484>, @beanz wrote:
>
> > We should not be adding more variables that are passed around by CMake's scope inheritance. Instead if we need to change this we should do it correctly.
>
>
> Just to clarify, the actions to take are to restore `LLVM_NO_DEAD_STRIP` in order to support other uses and then to replace its use as an internal variable? Given that direction, I agree the first course of action is to revert this patch and then to pursue a patch to do the replacement separately.

Based on the discussion, I will revert this change and open a new review introducing SUPPORT_PLUGINS as an option to the add_llvm_tool macro.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69356/new/

https://reviews.llvm.org/D69356