[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

Wed Oct 30 11:12:14 PDT 2019

beanz added a comment.

In D69356#1727451 <https://reviews.llvm.org/D69356#1727451>, @daltenty wrote:

> The intention of LLVM_SUPPORT_PLUGINS was as an internal option set by tools which may have plugins and need to be built in a specific way (such as avoiding deadstriping) if plugins are enabled.

Non-user facing options shouldn't be exposed this way. `LLVM_NO_DEAD_STRIP` has been around a long time and predates many of the modern CMake patterns. We should use arguments passed in explicitly to the calling functions rather than setting variables that are passed down.

> We could keep LLVM_NO_DEAD_STRIP as is and have it set by LLVM_SUPPORT_PLUGINS when appropriate. That should accommodate both uses.

We should not be adding more variables that are passed around by CMake's scope inheritance. Instead if we need to change this we should do it correctly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69356/new/

https://reviews.llvm.org/D69356