[PATCH] D69298: [clangd] Define out-of-line initial apply logic

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 30 08:17:57 PDT 2019


kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:55
+  // Include template parameter list.
+  if (auto *FTD = FD->getDescribedFunctionTemplate())
+    return FTD->getBeginLoc();
----------------
hokein wrote:
> Could you confirm the code handle template specializations as well? I think `getDescribedFunctionTemplate` will return null when FD is a specialization, and we still miss the template list.
added a unittest


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69298/new/

https://reviews.llvm.org/D69298





More information about the cfe-commits mailing list