[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 29 18:32:58 PDT 2019


arphaman accepted this revision.
arphaman added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:43
+
+class ModuleDepCollectorPP final : public PPCallbacks {
+public:
----------------
It would be nice if the dependency collector could be reused outside of `clang-scan-deps`, like for a new `-cc1` flag that computes the modular dependencies in the same fashion. However, its something that can be done as a follow-up, so for now this seems fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69420/new/

https://reviews.llvm.org/D69420





More information about the cfe-commits mailing list