[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

Chris Bieneman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 29 14:31:39 PDT 2019


beanz added a comment.

`LLVM_NO_DEAD_STRIP` isn't actually useful only for when plugins are enabled. It is also useful in a lot of contexts around building JIT host processes. The advantage of the old name was it specified exactly what it did (i.e. not dead strip code).

It seems to me that maybe a more appropriate approach is that `LLVM_SUPPORT_PLUGINS` implies `LLVM_NO_DEAD_STRIP`, rather than conflating the two options.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69356/new/

https://reviews.llvm.org/D69356





More information about the cfe-commits mailing list