[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK
Fangrui Song via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 29 10:07:58 PDT 2019
MaskRay added inline comments.
================
Comment at: lld/ELF/Driver.cpp:357
+
+ // default
+ return GnuStackKind::NoExec;
----------------
mgorny wrote:
> MaskRay wrote:
> > MaskRay wrote:
> > > This is obvious. The comment can be removed.
> > Not done. `// default` can be deleted I think.
> You didn't give me time to upload updated patch ;-).
You had plenty of time updating the patch but you still committed without changing this part...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56554/new/
https://reviews.llvm.org/D56554
More information about the cfe-commits
mailing list