[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1517
+    template <int x>
+    void foo(PARAM, TYPE b, TYPE c, TYPE d = BODY(x)){}
+
----------------
ilya-biryukov wrote:
> We fail to rename the parameter in that case, right?
> Should the action not be available or maybe show an error message?
> 
> Also ok with keeping the current behavior if we add a FIXME mentioning it would be nice to fix this.
somehow forgot my stashed changes ...

yes this was supposed to bail out on failure, but leave the macro occurrence if parameter names are the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68937/new/

https://reviews.llvm.org/D68937