[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1517
+    template <int x>
+    void foo(PARAM, TYPE b, TYPE c, TYPE d = BODY(x)){}
+
----------------
We fail to rename the parameter in that case, right?
Should the action not be available or maybe show an error message?

Also ok with keeping the current behavior if we add a FIXME mentioning it would be nice to fix this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68937/new/

https://reviews.llvm.org/D68937