[PATCH] D69543: [WIP][clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 29 03:19:05 PDT 2019


kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:127
+TEST_F(ObjCLocalizeStringLiteralTest, Test) {
+  ExtraArgs.push_back("-x=objective-c");
+  Context = Expression;
----------------
make sure this is rebased on top of http://github.com/llvm/llvm-project/commit/1a9c01c7f6c7e88676440869bbbe9f43fa45b109


================
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:129
+  Context = Expression;
+  EXPECT_AVAILABLE("@\"test string\"");
+}
----------------
maybe use raw string literals?
```
R"(@"teststring")"
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69543/new/

https://reviews.llvm.org/D69543





More information about the cfe-commits mailing list