[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

Dávid Bolvanský via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 28 10:51:26 PDT 2019


xbolva00 marked an inline comment as done.
xbolva00 added inline comments.


================
Comment at: clang/lib/Sema/SemaExprCXX.cpp:3679
+  CallExpr *Call = dyn_cast<CallExpr>(CondExpr->IgnoreParens());
+  if (IsConstexpr && Call && Call->isCallToStdIsConstantEvaluated())
+    Diag(Call->getBeginLoc(),
----------------
Not ideal place. Missing !E case, etc...


Maybe in ActOnCompletedExpr?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69518/new/

https://reviews.llvm.org/D69518





More information about the cfe-commits mailing list