[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

Mon Oct 28 09:47:37 PDT 2019

aaron.ballman added a comment.

In D68912#1723691 <https://reviews.llvm.org/D68912#1723691>, @xbolva00 wrote:

> >> Does this analysis require CFG support
>
> https://reviews.llvm.org/D69292 also requires CFG support.

Yes, it does.

> Generally, is CFG support ok for -Wall if the warning has few false positives?

I think it also depends on the performance of the diagnostic.

>>> I am wondering if the diagnostic was kept out of -Wall for a reason.
> 
> Yes, it would be good to find why this was disabled (never enabled?).
> 
> @Mordante can you compile LLVM itself with this patch?

I'd be curious to know how the timing changes between compilations as well; does this regress performance considerably?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68912/new/

https://reviews.llvm.org/D68912