[PATCH] D69511: [clangd] Do not report anonymous entities in findExplicitReferences

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 28 06:41:10 PDT 2019


kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/FindTarget.cpp:453
+      // and the clients are not prepared to handle that.
+      if (ND->getDeclName().isIdentifier() &&
+          !ND->getDeclName().getAsIdentifierInfo())
----------------
i believe this will break D68937, which relies on findExplicitReferences to even rename unnamed parameters.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69511/new/

https://reviews.llvm.org/D69511





More information about the cfe-commits mailing list