[PATCH] D69122: Add support to find out resource dir and add it as compilation args

[Kousik Kumar via Phabricator via cfe-commits]

kousikk added a comment.

I discussed with @klimek about this. The conclusion we arrived at was:

Allowing override of `resource-dir` for all tools is not something we should do (for reasons that @klimek has outlined above). However, the dependency scanner tool can choose to override `resource-dir`, iff we are sure that it would work across different versions of clang.

And my reasoning for why `resource-dir`'s behaviour when overridden in `clang-scan-deps` will remain the same across different versions of clang is:

1. The tool runs only the preprocessor. The preprocessor spec hasn't changed in a backwards incompatible way as far as I know.
2. In addition to (1), the tool doesn't use anything other than header files from `resource-dir`, for the purpose of dependency scanning from the preprocessor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69122/new/

https://reviews.llvm.org/D69122