[PATCH] D69479: [Sema] Warn about possible stack exhaution

Dávid Bolvanský via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Oct 27 10:09:25 PDT 2019


xbolva00 added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:12349
   // This is not the right CC for (e.g.) a variable initialization.
-  AnalyzeImplicitConversions(*this, E, CC);
+  analyzeImplicitConversionsWithSufficientStackSpace(*this, E, CC);
 }
----------------
xbolva00 wrote:
> Please do not change function names.
Ah, you had to change it.

Can this be solved maybe via new bool argument for AnalyzeImplicitConversions(.., arg)? If arg is false, we could just call S.runWithSufficientStackSpace(AnalyzeImplicitConversions(...., true)), otherwise continue in normal flow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69479/new/

https://reviews.llvm.org/D69479





More information about the cfe-commits mailing list