[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

[Chi Chun Chen via Phabricator via cfe-commits]

cchen added inline comments.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:4463-4890
+
   if (AStmt && !CurContext->isDependentContext()) {
     assert(isa<CapturedStmt>(AStmt) && "Captured statement expected");
 
     // Check default data sharing attributes for referenced variables.
     DSAAttrChecker DSAChecker(DSAStack, *this, cast<CapturedStmt>(AStmt));
+
----------------
ABataev wrote:
> The formatting changes better to put in a separate NFC patch if you think that this is required.
I don't really understand why adding a specific diagnostic message for defaultmap(none: x) is just a formatting change.  For defaultmap(none: x), we emit error message if there are no explicity specified data-sharing attributes, data mapping attributes, or is_device_ptr clause, while for default(none), we emit error message if there are no explicitly specified data-sharing attributes. So the message for defaultmap(none: x) should be different from default(none).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69204/new/

https://reviews.llvm.org/D69204