[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1466
       Output.Completions.back().Score = C.second;
       Output.Completions.back().CompletionTokenRange = ReplacedRange;
     }
----------------
why not handle `SnippetSuffix` in here ?

instead of propagating `IsUsingDeclaration`, we can just drop `Output.Completions.back().SnippetSuffix` in here, which sounds like a more appropriate layering.
considering we don't really have context specific knowledge in `CodeCompletionBuilder` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69382/new/

https://reviews.llvm.org/D69382