[PATCH] D69389: [hip] Allow the declaration of functions with variadic arguments in HIP.

[Artem Belevich via Phabricator via cfe-commits]

tra added inline comments.


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:7764
+                                 QualType Ty) const {
+  llvm_unreachable("AMDGPU does not support varargs");
+}
----------------
llvm_unreachable() should be used to indicate an error in compiler's own code, not in the user code that we're compiling. 

I think what you need to do is to issue a postponed diagnostics in Sema where we're currently checking for varargs functions and materialize them if we attempt to codegen such function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69389/new/

https://reviews.llvm.org/D69389