[clang] 7b3de1e - [ARM] Attempt to fixup MveEmitter warnings

David Green via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 24 11:44:51 PDT 2019


Author: David Green
Date: 2019-10-24T19:43:15+01:00
New Revision: 7b3de1e811972b874d91554642ccb2ef5b32eed6

URL: https://github.com/llvm/llvm-project/commit/7b3de1e811972b874d91554642ccb2ef5b32eed6
DIFF: https://github.com/llvm/llvm-project/commit/7b3de1e811972b874d91554642ccb2ef5b32eed6.diff

LOG: [ARM] Attempt to fixup MveEmitter warnings

Change-Id: I3fb06de2202c3b7a9ce511a40e758d0971ef9fdb

Added: 
    

Modified: 
    clang/utils/TableGen/MveEmitter.cpp

Removed: 
    


################################################################################
diff  --git a/clang/utils/TableGen/MveEmitter.cpp b/clang/utils/TableGen/MveEmitter.cpp
index 6fac472a7a19..c4270ff586cf 100644
--- a/clang/utils/TableGen/MveEmitter.cpp
+++ b/clang/utils/TableGen/MveEmitter.cpp
@@ -157,8 +157,6 @@ inline std::string toLetter(ScalarTypeKind kind) {
     return "u";
   case ScalarTypeKind::Float:
     return "f";
-  default:
-    llvm_unreachable("bad scalar type kind");
   }
 }
 inline std::string toCPrefix(ScalarTypeKind kind) {
@@ -169,8 +167,6 @@ inline std::string toCPrefix(ScalarTypeKind kind) {
     return "uint";
   case ScalarTypeKind::Float:
     return "float";
-  default:
-    llvm_unreachable("bad scalar type kind");
   }
 }
 
@@ -538,7 +534,7 @@ class BuiltinArgResult : public Result {
     OS << (AddressType ? "EmitPointerWithAlignment" : "EmitScalarExpr")
        << "(E->getArg(" << ArgNum << "))";
   }
-  virtual std::string typeName() const {
+  std::string typeName() const override {
     return AddressType ? "Address" : Result::typeName();
   }
 };


        


More information about the cfe-commits mailing list