[PATCH] D68340: Add AIX toolchain and basic linker functionality

Steven Wan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 24 11:32:20 PDT 2019


stevewan marked 2 inline comments as done.
stevewan added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:59
+
+  auto getCrt0Basename = [&IsArch32Bit, &Args] {
+    // Enable gprofiling when "-pg" is specified.
----------------
jasonliu wrote:
> nit: There is no need to capture IsArch32Bit by reference. 
Agreed. It's safer to capture IsArch32Bit by value here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68340/new/

https://reviews.llvm.org/D68340





More information about the cfe-commits mailing list