[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

Peter Waller via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 24 08:48:07 PDT 2019


peterwaller-arm updated this revision to Diff 226270.
peterwaller-arm added a comment.

I have rebased the patch for conflicts to master and all the tests are passing.

While doing so, I discovered that the test for flang-not-installed was not fit for purpose, because clang actually doesn't first check the PATH, it can find a flang binary which lives in the same directory as itself. I conclude that having such a test is more trouble than it is worth. Adding such a test would involve adding some questionable test-specific machinery. Therefore I've removed that test for now.

I'll leave the patch over the weekend in case anyone objects, otherwise I intend to submit early next week.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63607/new/

https://reviews.llvm.org/D63607

Files:
  clang/include/clang/Driver/Driver.h
  clang/include/clang/Driver/ToolChain.h
  clang/include/clang/Driver/Types.h
  clang/lib/Driver/CMakeLists.txt
  clang/lib/Driver/Driver.cpp
  clang/lib/Driver/ToolChain.cpp
  clang/lib/Driver/ToolChains/Flang.cpp
  clang/lib/Driver/ToolChains/Flang.h
  clang/lib/Driver/Types.cpp
  clang/test/Driver/flang/Inputs/one.f90
  clang/test/Driver/flang/Inputs/other.c
  clang/test/Driver/flang/Inputs/two.f90
  clang/test/Driver/flang/flang.F90
  clang/test/Driver/flang/flang.f90
  clang/test/Driver/flang/multiple-inputs-mixed.f90
  clang/test/Driver/flang/multiple-inputs.f90
  clang/test/Driver/fortran.f95
  clang/test/Driver/lit.local.cfg

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63607.226270.patch
Type: text/x-patch
Size: 19481 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191024/fe22854e/attachment-0001.bin>


More information about the cfe-commits mailing list