[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Wed Oct 23 12:05:09 PDT 2019

MyDeveloperDay added a comment.

You know that feeling when you are doing a review and you think... I'm just not a compiler... I feel given the previous discussion and the level of extra tests maybe this is just worth going ahead with as long as you are prepared to support it in the interim.

================
Comment at: clang/unittests/Format/FormatTest.cpp:5739
+               "                  ? ccccccccccccccc\n"
+               "                  : ddddddddddddddd;");
   verifyFormat("bool aaaaaa = aaaaaaaaaaaaa //\n"
----------------
Nit: I'm just slightly confused as to what is happening here.. I assume this is the case where they are not aligned in the style. 

================
Comment at: clang/unittests/Format/FormatTest.cpp:5998
+               "                  ddddddddddddddd;",
                Style);
   verifyFormat("bool aaaaaa = aaaaaaaaaaaaa ? //\n"
----------------
as above how does one get back to the original case?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50078/new/

https://reviews.llvm.org/D50078