[PATCH] D69329: [clangd] abort if shutdown takes more than a minute.

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

Sorry I somehow missed the fact that I was a reviewer :D

LGTM



================
Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:219
+  // destroyed first, to ensure worker threads don't access other members.
+  llvm::Optional<ClangdServer> Server;
 };
----------------
ilya-biryukov wrote:
> Maybe call `Server.reset()` in destructor?
> This ensures `ClangdServer` is terminated first even if the members are re-ordered later
+1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69329/new/

https://reviews.llvm.org/D69329